Remove flaky test_escape_html_allocates_same_as_escapeHTML#128
Merged
Conversation
It's causing ruby CI to flake, because it's a badly designed test, a lot of thing can cause acouple extra allocation there and there so even if you invoke the exact same code twice, you might still allocate a bit more or a bit less.
Member
Author
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's causing ruby CI to flake, because it's a badly designed test, a lot of thing can cause acouple extra allocation there and there so even if you invoke the exact same code twice, you might still allocate a bit more or a bit less.